"That doesn't mean the current iPhone X was too expensive, though, as in February, Apple said it was the
"top selling iPhone" every week since it launched in early November."
That could mean that for example the share was iPhoneX 34%, iPhone8 33%, iPhone8+ 33%. So yes, it could have been the top selling but if you look at the iPhone8 line, it sold much better than the X. Of course they're very careful with their words.
What I'd most be interested in is what is iPhoneX vs all other iPhones, that would tell you how much people are actually adopting the latest and greatest.