I went from the XS to the 11 Pro Max so for me, it was worth it just to get the screen size I should have chosen last year.
Size aside, while I probably wouldn’t have upgraded if I’d got the XS Max last year, the camera and battery improvements are compelling enough reasons in themselves if you’re OK with the cost. Anybody who’s in two minds, I’d say don’t bother.