This is the transition I recently made. I never used FaceID/had an OLED screen before, so the upgrade was significant for me. I tend to upgrade every two years, as I feel that that way you see a real difference between the models. Personally think upgrading every year is silly, and individuals won’t see much of a difference. But I also understand that it’s nice to have the latest and greatest.
Yeah, it's pretty fun when the user experience is a major change. I do the same, wait a couple of years so I really feel the impact of the new device - going from a pre-OLED/FID device to an X/XS/Pro is pretty shocking (in the best possible way).