I don't think this year's iPhone release will be a failure. They are still going to sell gobs and gobs of new iPhones and make billions of dollars. I would say, however that I think the majority of those calling this new iPhone generation a failure are meaning it in the sense that there will be no new features to make a person's heart skip a beat and have them run to the nearest Apple store with the credit card already in hand and say "Apple, take mah monies, right meow!".
I can see though from your perspective of having an iPhone 7 currently, that the new features would be innovative and exciting. I have an XS Max and I don't think think there will be any features compelling enough to prompt me to upgrade, unless Apple managed to hide something from us that will be completely game changing.
one thing for me that may be minor to most is that the pro is rumored to have improved haptics, which is actually one of my favorite things about the 7 versus its predecessors. The camera stuff is ok but i think it’ll the culmination of “small” stuff like haptics which i will appreciate the most upgrading from my 7