I may be part of the minority but the storage options finally look decent to me. I always approach upgrade cycles as, "is this worth it?" If I can't answer a definite yes, I buy AAPL instead.
This has me sitting on a iPhone 6 still and I now feel like the storage is finally in line and pricing for the regular customer. To me, Apple Music and such help people not need the full blown storage options. While I use Apple Music, I still store all my "favorite and must have music" on my phone.
I honestly don't see what people need 256gb/512gb in a phone? I create content too and the only thing I can think of is the people that never delete anything. That falls under the Apple services side as well with iCloud.