Coming from a 7/128, I decided to upgrade to the 8+ 256. I got the 8+ delivered on release day, and kept it for 10 days and decided to return it. It's a great phone, but the glass back is just WAY to slippery. The phone slipped off everything, flat books (that apparently wasn't completely flat, but to my eyes they were), off the bed, off chairs, everything. The 8+ is to big to put covers on, as it just becomes too big. I also didn't like the weight increase of it, it's significantly heavier than the 6+ I had some years ago. I loved the battery time on it though!
I've gone back to my 7/128, and waiting... I'm considering pre-ordering an X, but, I would rather wait for the rumored X Plus or whatever it's gonna be called. The X will only make the length of the screen bigger, but the overall experience will be more or less the same.
If the general availability of the X is pushed back into 2018, especially towards march/2018, then i'm afraid a lot of people will skip it and rather wait for the fall 2018 refresh - me included.